Introduce overridable protocol implementations #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y86
commented
Aug 25, 2023
| @@ -0,0 +1,49 @@ | |||
| defmodule Msgpax.Ext.OverwriteTest do | |||
| use Msgpax.Case, async: false | |||
There was a problem hiding this comment.
These tests need to be the last one to be run so that the overwrites don't affect the other tests. Hence the async: false, as ExUnit first loads async: true tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #67
Closes #60
Enables the solution of #61 and #62
The goal of this PR is to introduce a way for users to override default implementations from the library, In order to achieve that, several changes were introduced:
Msgpax.Ext, we have 128 structs, one for each extension type;Msgpax.Unpackerprotocol that can be dispatched against the specificMsgpax.Ext#structs;Msgpax.Ext.defimplmacro to allow users to overwrite protocol implementations without triggering warnings about module redefinition;