Global sample rate #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaro-m
force-pushed
the
global-sample-rate
branch
from
602c0fc
to
dc7ee61
Compare
lexmag
requested changes
Apr 16, 2018
lib/statix.ex
Outdated
| @@ -335,8 +335,9 @@ defmodule Statix do | |||
| @doc false | |||
| def transmit(conn, type, key, val, options) | |||
| when (is_binary(key) or is_list(key)) and is_list(options) do | |||
| sample_rate = Keyword.get(options, :sample_rate) | |||
| sample_rate = Keyword.get(options, :sample_rate, Application.get_env(:statix, :sample_rate)) | |||
There was a problem hiding this comment.
I think instead of fetching the value from env each call we should read it once and store in the connection struct.
There was a problem hiding this comment.
Looks reasonable. Let me update PR and see if I'm on right track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set the global sample rate