Fixes for python3 and added file output. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Danixu
commented
Jan 18, 2021
Danixu
commented
- Fixed some forgotten unichr that were failing on python3
- Fixed the stdout piping to file when the font contains non unicode characters (was failing on Python 3.9.1 and Windows)
- Added an option to save the output to a file directly
- Tested on Windows + Python 3.9.1, Debian 9 WSL (Windows Subsystem for Linux) + Python 2.7 & 3.7
|
|
|
Hello. I reviewed your changes. All of them look clear for me. |
|
Thank you. |
|
You are welcome! I'm glad it helped you. Thank you for the library!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.