Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make run pulls in ../adam/run if it exists, breaking things #948

Closed
deitch opened this issue Apr 30, 2020 · 1 comment
Closed

make run pulls in ../adam/run if it exists, breaking things #948

deitch opened this issue Apr 30, 2020 · 1 comment

Comments

@deitch
Copy link
Contributor

deitch commented Apr 30, 2020

Description

The Makefile here sets:

CONF_PART=$(CURDIR)/../adam/run/config

and then includes it here as:

QEMU_OPTS_CONF_PART=$(shell [ -d $(CONF_PART) ] && echo '-drive file=fat:rw:$(CONF_PART),format=raw')

This means that if someone has the adam repo in the right place, whatever they are using will show up rather suddenly. This sucks the default runtime config for adam as a standalone into a running eve.

This should just be removed

cc @rvs

Steps to Reproduce

  1. Run adam in its usual place
  2. Run eve
  3. See that the config is loaded from there
@rvs
Copy link
Contributor

rvs commented Apr 30, 2020

This is such a 🤦 -- and yes -- I'm burning it with 🔥 now @deitch

rvs added a commit to rvs/eve that referenced this issue Apr 30, 2020
Signed-off-by: Roman Shaposhnik <rvs@zededa.com>
@rvs rvs closed this as completed in 08e0866 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants