Move datastore configuration handling to downloader. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinibas Maharana <srinibas@zededa.com>
Signed-off-by: Srinibas Maharana <srinibas@zededa.com>
Signed-off-by: Srinibas Maharana <srinibas@zededa.com>
eriknordmark
reviewed
Aug 7, 2019
| @@ -544,16 +526,6 @@ func handleCreate(ctx *zedmanagerContext, key string, | |||
| } | |||
| publishAppInstanceStatus(ctx, &status) | |||
There was a problem hiding this comment.
Old code checked for status,Error != "' here. Why do we no longer need that check?
There was a problem hiding this comment.
Will add the check, missed during code removal. thanks.
eriknordmark
approved these changes
Aug 7, 2019
Signed-off-by: Srinibas Maharana <srinibas@zededa.com>
milan-zededa
pushed a commit
to milan-zededa/eve
that referenced
this pull request
Nov 7, 2023
pull the latest eve 7/20/2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. The downloadable objects will be published to downloader, without datastore config.
b. removed the datastore configuration items from DownloaderConfig/Status structure
a. Added pubsub config handler functions for datastore config changes from zedagent
b. For every downloadable object config change, we will check for availability of data
store configuration.
c. For evert datastore configuration change, pick up the objects attached to the datastore
still in error state, for downloading.