-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish cellular info and metrics to apps #2616
Conversation
9c58360
to
0dcfe7a
Compare
@eriknordmark I'm also considering to create a meta-data server endpoint with ALL LTE-related information, i.e. not just metrics, but also info about the modem hardware, firmware, SIM cards, etc. - just like what we publish to LPS under |
If we think the metrics (whether LTE or WiFi) will see significantly more use than the info then maybe we should have /eve/v1/radio/{info,metrics}.json. But it makes sense to look at how cloud-init (whether AWS or openstack) tends to structure the URLs they use on 169.254 |
It seems that your suggestion is in line with the AWS approach of structuring URLs, so I'm going to make the changes and mark the PR as draft for the time being. |
0dcfe7a
to
2e1d439
Compare
Provided that device has at least one cellular modem visible to EVE (i.e. not assigned directly to an application), JSON-formatted WWAN metrics are made available to all applications on the `/eve/v1/network/wwan/metrics.json` endpoint. This includes packets counters as recorded by modems as well as cellular signal strength info. Signed-off-by: Milan Lenco <milan@zededa.com>
Added cellular metrics (packet counters and signal strength) to the "/api/v1/radio" endpoint of the Local Profile Server (LPS). Signed-off-by: Milan Lenco <milan@zededa.com>
2e1d439
to
5448d67
Compare
5448d67
to
b6d0fc7
Compare
Provided that device has at least one cellular modem visible to EVE (i.e. not assigned directly to an application), JSON-formatted WWAN status information are made available to all applications on the `/eve/v1/network/wwan/status.json` endpoint. This includes information about the installed cellular equipment (modem(s) and SIM card(s)), identity information (IMEI, IMSI, ICCID), available network providers (PLMNs) and more. Signed-off-by: Milan Lenco <milan@zededa.com>
b6d0fc7
to
56393d2
Compare
@eriknordmark I have split the metrics and status info into separate metadata server endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one question as a separate comment.
Provided that device has at least one cellular modem visible to EVE (i.e. not assigned directly to an application),
JSON-formatted WWAN status and metrics are made available to all applications on the
/eve/v1/wwan/status.json
/eve/v1/wwan/metrics.json
meta-data server endpoints, respectivelly.This includes information about the cellular equipment, operating state, packet counters as recorded by modems, signal strength metrics and more.
Additionally, as a separate commit, cellular metrics were added to
RadioStatus
proto message, published by EVE to/api/v1/radio
endpoint of the Local Profile Server (LPS).