Report per-vault status to Controller #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
…control thread. Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
eriknordmark
requested changes
Oct 9, 2019
probe support for intf class, change flag, etc add signal to update route/acl, add prev uplink add checking IoBundle for type of uplink intfs App uplink fallback programming initial commit change to NI uplink name for probing info and add/delete handling added handling of user defined url/interval fixed a zero ip checking in getRemoteURL() Change from IntfClass to Free/NonFree, add initial signal for Uplink failover with vpn network, commit on behalf of Gopi sending ni status update, commit on behalf of Gopi remove publish ni status for every probing dnsmasq should get the upstream DNS that comes as part of DHCP for the current uplink interface decided by probing code. Do not delete hosts configuration when restarting dnsmasq probe support for intf class, change flag, etc add signal to update route/acl, add prev uplink add checking IoBundle for type of uplink intfs App uplink fallback programming initial commit added handling of user defined url/interval Change from IntfClass to Free/NonFree, add initial signal for Uplink dnsmasq should get the upstream DNS that comes as part of DHCP for the current uplink interface decided by probing code. Do not delete hosts configuration when restarting dnsmasq specify DNS IP source address for dnsmasq for failover Fix code path when app network creation is re-tried due to network instance not being present during the first time. Probing code should pick a port that has atleast one workable IP address. Other misc fixes. add fast converge with link address/first pingable prevent triggering probe too frequently with link up/down change some logging from info to debug send ni-status update when any state changes, for reduce logging ctx.networkInstanceStatusList should be updated with latest network status during publish Initial checkin for local/remote network probing for uplinks probe support for intf class, change flag, etc add signal to update route/acl, add prev uplink add checking IoBundle for type of uplink intfs App uplink fallback programming initial commit added handling of user defined url/interval Change from IntfClass to Free/NonFree, add initial signal for Uplink remove publish ni status for every probing dnsmasq should get the upstream DNS that comes as part of DHCP for the current uplink interface decided by probing code. Do not delete hosts configuration when restarting dnsmasq Initial checkin for local/remote network probing for uplinks probe support for intf class, change flag, etc add signal to update route/acl, add prev uplink add checking IoBundle for type of uplink intfs App uplink fallback programming initial commit added handling of user defined url/interval Change from IntfClass to Free/NonFree, add initial signal for Uplink dnsmasq should get the upstream DNS that comes as part of DHCP for the current uplink interface decided by probing code. specify DNS IP source address for dnsmasq for failover add fast converge with link address/first pingable prevent triggering probe too frequently with link up/down change some logging from info to debug ctx.networkInstanceStatusList should be updated with latest network status during publish When a network instance starts with working port and ends up in a state where is no working port found, atleast do not overwrite the existing port - programming. fix the free/non-free and ni update issues avoid stale PInfo for current unused ports Addressed review comments. Fixed a bug in the latest code that precents network instances with single port attached from working as expected. Signed-off-by: Naiming Shen <naiming@zededa.com> Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com> Signed-off-by: eriknordmark <erik@zededa.com>
…should be written to /etc/resolv.conf irrespective of having AddrInfoList populated. Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
…e just let the DNS servers be written irrespective of presence of IPs on the port. Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
pkg/pillar/cmd/vaultmgr/vaultmgr.go
Outdated
| switch flag.Args()[0] { | ||
| case "setupVaults": | ||
| if err = setupFscryptEnv(); err != nil { | ||
| publishVaultStatus(&ctx, defaultImgVaultName) |
There was a problem hiding this comment.
How is publish followed by log.Fatal useful?
The subscriber is not going to receive it since the publisher is gone.
There was a problem hiding this comment.
Perhaps you shouldn't Fatal?
Perhaps feed err into publish??
There was a problem hiding this comment.
Addressed in the latest patch.
pkg/pillar/cmd/vaultmgr/vaultmgr.go
Outdated
| @@ -280,39 +280,51 @@ func setupFscryptEnv() error { | |||
| return nil | |||
| } | |||
|
|
|||
| //GetOperInfo gets the current operational state of fscrypt | |||
| func GetOperInfo() (info.DataSecAtRestStatus, string, []VaultStatus) { | |||
| func publishVaultStatus(ctx *vaultMgrContext, vaultName string) { | |||
There was a problem hiding this comment.
Why do you need to do the execCmd for each vaultName? Seems to be unrelated to the name of a particular vault.
There was a problem hiding this comment.
Addressed in the latest patch.
…ddr logic boundary handling fix. App IP address allocation should propagate error to AppNetworkStatus Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Jack Ren <jack.ren@intel.com>
Signed-off-by: Roman Shaposhnik <rvs@zededa.com>
Signed-off-by: Naiming Shen <naiming@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
…dapterConfig Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: GopiKrishna Kodali <gkodali@zededa.com>
Signed-off-by: Kalyan Nidumolu <kalyan@zadeda.com>
Signed-off-by: zed-rishabh <rgupta@zededa.com> Signed-off-by: eriknordmark <erik@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
…update 1 Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> (+22 squashed commits) Squashed commits: [cb3fdfe] removed comment Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [3f835c8] removed old comment Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [5a1b2ab] renamed variable Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [041f058] renmaed function Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [9360b23] resolved issues with 673-677 of zedrouter Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [06e02a4] resolved issues with 777-787 of zedrouter Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [53ce2b0] addressed comments for zedrouter Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [caa5835] removed .idea dir Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [047f337] fixed identitymgr to address comments Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [8e38803] updated zedrouter.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [28ac54c] updated zedmanger.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [11e7e97] updated some more files Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [3059a0e] updated verifier.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [4c03697] updated nim.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [970063f] updated logmanager.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [6ad26fb] updated ledmanager.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [5bf1c80] updated identitymgr.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [2033fcb] updated downloader.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [db7f228] updated domainimg.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [ffa47a6] updated diag.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [b41a387] updated dataplane.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> [c41f655] updated client.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com> (+1 squashed commit) Squashed commits: [2ace073] updated baseosmgr.go Signed-off-by: Archishmaan Peyyety <archishou@gmail.com>
Signed-off-by: Archishmaan Peyyety <archishou@gmail.com>
Signed-off-by: Archishmaan Peyyety <archishou@gmail.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
Signed-off-by: Hariharasubramanian C S <cshari@zededa.com>
|
I've messed up this PR with some improper usage of git commands. I will discard this PR and re-open a new one. Sorry for the trouble. |
andrewd-zededa
pushed a commit
to andrewd-zededa/eve
that referenced
this pull request
Aug 17, 2024
pull the latest of 7/11/2024 eve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hariharasubramanian C S cshari@zededa.com