Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dell 300x series] improve installer support #324

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

zach-welch-timesys
Copy link
Contributor

This series of patches improves support for the Dell Edge Gateway 3000 series hardware.

Principally, a new document describing the quirks and tricks for using its hardware is added in a new subdirectory (docs/targets/). This document describes the current state of affairs for using the hardware and provides notes that would allow further development of improvements to proceed. Notably, it references using the Dell Configure | Control utility on the official Dell Ubuntu Server image, along with some information about the various peripherals that will assist with sorting out missing driver and user space support.

Beyond documentation, this series makes two minor changes to make the installer work seamlessly on these targets:

  1. Adds a UsbInvocationScript.txt file to the configuration partition to make the target boot the installer automatically when powered on with the USB drive in place. See issue [Dell 300x series] Add UsbInvocationScript.txt #313
  2. Adds console=ttyS0 to the kernel boot arguments in grub, allowing the internal serial port to be used as console on the headless targets (3001/3002). See issue [Dell 300x series] serial console support #318

With those changes, the standard installer image works seamlessly for the 3001/3002/3003 hardware. The USB key boots the installer, the live image is installed on its internal storage, the live system boots, and the system can be used via the serial console.

Makefile Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
usb_disable_secure_boot noreset;
usb_one_time_boot usb nolog;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check whether UsbInvocationScript.txt allows comments at all so we can provide breadcrumbs in the file itself about where this came from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was generated by their custom tool, and its format does not appear to be documented anywhere. Indeed, one of my replies to Jason was to request the complete syntax/grammar of these files. Thus, I think it would be an undue risk to add comments directly in the file. I can, however, add a small blurb to the target documentation that I've drafted, so these options are documented within the EVE source tree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Since you'll be moving this file to pkg/mkimage-raw-efi you can provide ample comments in Dockerfile there

Signed-off-by: Zachary T Welch <zach.welch@timesys.com>
Signed-off-by: Zachary T Welch <zach.welch@timesys.com>
Signed-off-by: Zachary T Welch <zach.welch@timesys.com>
Copy link
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@rvs rvs merged commit 65a8600 into lf-edge:master Oct 14, 2019
@zach-welch-timesys zach-welch-timesys deleted the dell-300x branch October 15, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants