-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0-stable] Bump Eden to 0.9.3 #3796
[11.0-stable] Bump Eden to 0.9.3 #3796
Conversation
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Node 16 is EOL and it was used in checkout and upload-artifact actions v3. Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 11.0-stable #3796 +/- ##
===============================================
- Coverage 20.27% 20.27% -0.01%
===============================================
Files 212 212
Lines 46125 46125
===============================================
- Hits 9354 9351 -3
- Misses 36088 36091 +3
Partials 683 683 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this
@uncleDecart eden tests do not seem to get triggered (the workflow does not even seem to appear in the list). |
712e3ae
to
f74c250
Compare
@milan-zededa merging magic went wrong, fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run it.
Eden tests appear to be failing with |
Ah, I guess cloud-init wasn't ported into 11.0-stable, am I right @europaul ? |
No, it was not. it only appears in 11.3.0 and after. This is not a fix, but a feature, so we didn't backport it. |
@eriknordmark shouldn't 11-stable be ahead of 11.3.0? If not we can bump eden to 0.9.3 instead of 0.9.6 |
11.0-stable is 11.0, not 11.3+. |
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
f74c250
to
b27a93f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run eden again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this and it fails. See https://github.com/lf-edge/eve/actions/runs/8256319988
We already bumped Eden tests to 0.9.6 in 11.8, this commit bumps it to 0.9.3 in 11.0 stable branch.