Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0-stable] Bump Eden to 0.9.3 #3796

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

uncleDecart
Copy link
Contributor

@uncleDecart uncleDecart commented Mar 6, 2024

We already bumped Eden tests to 0.9.6 in 11.8, this commit bumps it to 0.9.3 in 11.0 stable branch.

deitch and others added 3 commits March 6, 2024 10:20
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Node 16 is EOL and it was used in checkout and upload-artifact
actions v3.

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.27%. Comparing base (3936a43) to head (b27a93f).
Report is 9 commits behind head on 11.0-stable.

Additional details and impacted files
@@               Coverage Diff               @@
##           11.0-stable    #3796      +/-   ##
===============================================
- Coverage        20.27%   20.27%   -0.01%     
===============================================
  Files              212      212              
  Lines            46125    46125              
===============================================
- Hits              9354     9351       -3     
- Misses           36088    36091       +3     
  Partials           683      683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@milan-zededa milan-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this

@milan-zededa
Copy link
Contributor

@uncleDecart eden tests do not seem to get triggered (the workflow does not even seem to appear in the list).

@uncleDecart
Copy link
Contributor Author

@milan-zededa merging magic went wrong, fixed it

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run it.

@eriknordmark
Copy link
Contributor

Eden tests appear to be failing with
eclient lfedge/eden-eclient:b1c1de6 2cbd4a79-1c33-4ede-97f3-53c9f58c0b6c -:22 127.0.0.1:2223 0 B/0 B IN_CONFIG INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable "#cloud-config" not defined properly\nKey value pair should be delimited by "="" timestamp:{seconds:1709737368 nanos:66690152} severity:SEVERITY_ERROR]

@uncleDecart
Copy link
Contributor Author

Eden tests appear to be failing with
eclient lfedge/eden-eclient:b1c1de6 2cbd4a79-1c33-4ede-97f3-53c9f58c0b6c -:22 127.0.0.1:2223 0 B/0 B IN_CONFIG INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable "#cloud-config" not defined properly\nKey value pair should be delimited by "="" timestamp:{seconds:1709737368 nanos:66690152} severity:SEVERITY_ERROR]

Ah, I guess cloud-init wasn't ported into 11.0-stable, am I right @europaul ?

@europaul
Copy link
Contributor

europaul commented Mar 7, 2024

Eden tests appear to be failing with
eclient lfedge/eden-eclient:b1c1de6 2cbd4a79-1c33-4ede-97f3-53c9f58c0b6c -:22 127.0.0.1:2223 0 B/0 B IN_CONFIG INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable "#cloud-config" not defined properly\nKey value pair should be delimited by "="" timestamp:{seconds:1709737368 nanos:66690152} severity:SEVERITY_ERROR]

Ah, I guess cloud-init wasn't ported into 11.0-stable, am I right @europaul ?

No, it was not. it only appears in 11.3.0 and after. This is not a fix, but a feature, so we didn't backport it.

@uncleDecart
Copy link
Contributor Author

@eriknordmark shouldn't 11-stable be ahead of 11.3.0? If not we can bump eden to 0.9.3 instead of 0.9.6

@eriknordmark
Copy link
Contributor

@eriknordmark shouldn't 11-stable be ahead of 11.3.0? If not we can bump eden to 0.9.3 instead of 0.9.6

11.0-stable is 11.0, not 11.3+.

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@eriknordmark eriknordmark changed the title [11.0-stable] Bump Eden to 0.9.6 [11.0-stable] Bump Eden to 0.9.3 Mar 12, 2024
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run eden again

@eriknordmark eriknordmark merged commit dca93e0 into lf-edge:11.0-stable Mar 12, 2024
15 of 16 checks passed
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants