Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: rework k3s install path, restart k3s. #3883

Merged

Conversation

andrewd-zededa
Copy link
Contributor

Rework the k3s install steps to allow watching
the containerd and k3s processes for crashes and
restarting them. Also reduce duplicated code in
k3s startup down to one spot in check_start_k3s().

Part 4 of broken up: #3838

@andrewd-zededa andrewd-zededa force-pushed the andrewd-kubevirt-longhorn-part4 branch from aa54809 to 56e4caf Compare April 25, 2024 15:13
@andrewd-zededa
Copy link
Contributor Author

@zedi-pramodh @eriknordmark All checks are passing and I believe reviews have been addressed here. Please review as time allows. Thanks

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kick off tests. Still some questions around the sleeps. We should at least comment those.

Rework the k3s install steps to allow watching
the containerd and k3s processes for crashes and
restarting them. Also reduce duplicated code in
k3s startup down to one spot in check_start_k3s().

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
@andrewd-zededa andrewd-zededa force-pushed the andrewd-kubevirt-longhorn-part4 branch from 56e4caf to 8db311e Compare April 26, 2024 02:17
@eriknordmark eriknordmark merged commit 574d447 into lf-edge:master Apr 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants