[12.0 stable] Allow device access when loading OCI spec from file #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouming
approved these changes
May 28, 2024
|
Can we do these backport PRs/commits so that the commit and PR messages reference to the commit in master? See for instance the commits in #3943) |
Since the update to runc v1.1.0 and containerd v1.6.1 in 158cecd we need to explicitly allow device access in the OCI config. This is done when generating a new OCI spec. However, when loading an OCI config from a file, we need to make sure that the device access is added, because older OCI configs may lack this configuration. Signed-off-by: Paul Gaiduk <paulg@zededa.com> (cherry picked from commit 17d9a41)
That absolutely makes sense! I re-ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the update to runc v1.1.0 and containerd v1.6.1 in 158cecd we need to explicitly allow device access in the OCI config. This is done when generating a new OCI spec.
However, when loading an OCI config from a file, we need to make sure that the device access is added, because older OCI configs may lack this configuration.
(cherry picked from commit 17d9a41)