pillar: Release CPUs on domain activation failure.

[OhmSpectator]

This commit addresses an issue where CPUs assigned to a domain within doActivate() are not released if the domain activation fails. The new logic ensures that CPUs are properly released and the CPU mask in the status is updated accordingly. This is achieved by introducing the releaseCPUs function and calling it in the appropriate error handling blocks within doActivate().

It is common for doActivate to fail in scenarios such as switching application profiles that share the same adapter. In such cases, the second application will fail to activate until the first one releases the necessary adapter.

[OhmSpectator]

A strange failure on the PR build

+ echo docker run -i --rm -u runner -w /go/src/github.com/lf-edge/eve/pkg/pillar -v /home/runner/actions-runner/_work/eve/eve/.go:/go:z -v /home/runner/actions-runner/_work/eve/eve/pkg/pillar:/go/src/github.com/lf-edge/eve/pkg/pillar:z -v /home/runner/actions-runner/_work/eve/eve/build-tools/bin:/go/bin:z -v /home/runner/actions-runner/_work/eve/eve/:/eve:z -v /home/runner:/home/runner:z -e GOOS -e GOARCH -e CGO_ENABLED -e BUILD=local eve-build-runner bash --noprofile --norc -c "unset GOFLAGS; rm -rf /tmp/linuxkit && git clone https://github.com/linuxkit/linuxkit.git /tmp/linuxkit && cd /tmp/linuxkit && git checkout e6b0ae05eb3a2b99e84d9ffc03a3a5c9c3e7e371 && if [ -e /eve/tools/linuxkit/patches ]; then     patch -p1 < /eve/tools/linuxkit/patches/*.patch; fi && cd /tmp/linuxkit/src/cmd/linuxkit && GO111MODULE=on CGO_ENABLED=0 go build -o /go/bin/linuxkit -mod=vendor . && cd && rm -rf /tmp/linuxkit"
+ docker run -i --rm -u runner -w /go/src/github.com/lf-edge/eve/pkg/pillar -v /home/runner/actions-runner/_work/eve/eve/.go:/go:z -v /home/runner/actions-runner/_work/eve/eve/pkg/pillar:/go/src/github.com/lf-edge/eve/pkg/pillar:z -v /home/runner/actions-runner/_work/eve/eve/build-tools/bin:/go/bin:z -v /home/runner/actions-runner/_work/eve/eve/:/eve:z -v /home/runner:/home/runner:z -e GOOS -e GOARCH -e CGO_ENABLED -e BUILD=local eve-build-runner bash --noprofile --norc -c unset GOFLAGS; rm -rf /tmp/linuxkit && git clone https://github.com/linuxkit/linuxkit.git /tmp/linuxkit && cd /tmp/linuxkit && git checkout e6b0ae05eb3a2b99e84d9ffc03a3a5c9c3e7e371 && if [ -e /eve/tools/linuxkit/patches ]; then     patch -p1 < /eve/tools/linuxkit/patches/*.patch; fi && cd /tmp/linuxkit/src/cmd/linuxkit && GO111MODULE=on CGO_ENABLED=0 go build -o /go/bin/linuxkit -mod=vendor . && cd && rm -rf /tmp/linuxkit
docker run -i --rm -u runner -w /go/src/github.com/lf-edge/eve/pkg/pillar -v /home/runner/actions-runner/_work/eve/eve/.go:/go:z -v /home/runner/actions-runner/_work/eve/eve/pkg/pillar:/go/src/github.com/lf-edge/eve/pkg/pillar:z -v /home/runner/actions-runner/_work/eve/eve/build-tools/bin:/go/bin:z -v /home/runner/actions-runner/_work/eve/eve/:/eve:z -v /home/runner:/home/runner:z -e GOOS -e GOARCH -e CGO_ENABLED -e BUILD=local eve-build-runner bash --noprofile --norc -c "unset GOFLAGS; rm -rf /tmp/linuxkit && git clone https://github.com/linuxkit/linuxkit.git /tmp/linuxkit && cd /tmp/linuxkit && git checkout e6b0ae05eb3a2b99e84d9ffc03a3a5c9c3e7e371 && if [ -e /eve/tools/linuxkit/patches ]; then     patch -p1 < /eve/tools/linuxkit/patches/*.patch; fi && cd /tmp/linuxkit/src/cmd/linuxkit && GO111MODULE=on CGO_ENABLED=0 go build -o /go/bin/linuxkit -mod=vendor . && cd && rm -rf /tmp/linuxkit"
Cloning into '/tmp/linuxkit'...
error: 264 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

@uncleDecart, is it runner-related?...

[OhmSpectator]

Once merged, the PR is to be backported into:

• 12.0
• 11.0-stable
• 10.4-stable
• 9.4-stable

[eriknordmark]

LGTM

[OhmSpectator]

Not sure, why the TMP tests fail...

/home/runner/actions-runner/_work/eve/eve/eden/dist/bin/eden sdn fwd eth0 2223 -- ssh -o ConnectTimeout=10 -o StrictHostKeyChecking=no -i /home/runner/actions-runner/_work/eve/eve/eden/dist/tests/eclient/image/cert/id_rsa root@FWD_IP -p FWD_PORT grep -q "before_restart" /etc/injected_file.txt
        Try 1
        time="2024-05-29T14:43:05Z" level=fatal msg="command ssh failed: exit status 255"
        Try 2
        time="2024-05-29T14:43:17Z" level=fatal msg="command ssh failed: exit status 255"
        Try 3
        time="2024-05-29T14:43:29Z" level=fatal msg="command ssh failed: exit status 255"
        Try 4
        [stderr]
        Connection timed out during banner exchange
        Connection to 127.0.0.1 port 2223 timed out
        Connection timed out during banner exchange
        Connection to 127.0.0.1 port 2223 timed out
        Connection timed out during banner exchange
        Connection to 127.0.0.1 port 2223 timed out
        [context deadline exceeded]
        FAIL: ../eclient/testdata/userdata.txt:41: command failure