Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: build.yml: add platform parameter #3957

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

uncleDecart
Copy link
Contributor

This parameter allows us to build RT flavor of EVE and publish it as well as NVIDIA, Pollux and IMX flavours of EVE for ARM

@uncleDecart
Copy link
Contributor Author

As per request by @rouming and @rene

@eriknordmark
Copy link
Contributor

@uncleDecart for some reason the PR doesn't run the build workflow with these changes (hence get-run-id fails)

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are conflicts to resolve

@uncleDecart
Copy link
Contributor Author

@rouming I added also platform to buildondemand action which we can invoke manually to try it out

Copy link
Contributor

@rouming rouming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to approve, but I didn't see the build run from Roman's approval so it looks like the issue is still present.

@eriknordmark
Copy link
Contributor

Try to approve, but I didn't see the build run from Roman's approval so it looks like the issue is still present.

Yes, the build still does not produce output hence get run id fails.

@uncleDecart
Copy link
Contributor Author

Okay, found a problem in yml file, fixed. Should work now

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build works, but the eden pr workflow fails across the board with
Error: Unable to download artifact(s): Artifact not found for name: eve-kvm-amd64

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again

@uncleDecart
Copy link
Contributor Author

Okay, we will have to change eve artefact name. On it...

@eriknordmark
Copy link
Contributor

Try again

And it failed with the same issue again:
Error: Unable to download artifact(s): Artifact not found for name: eve-kvm-amd64

@uncleDecart I will politely ignore this PR until I get a positive confirmation that this issue has been fixed.

This parameter allows us to build RT flavor of EVE and publish it
as well as NVIDIA, Pollux and IMX flavours of EVE for ARM

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart
Copy link
Contributor Author

@eriknordmark tests started to work, failures seems not related to changes in GitHub Actions. Image is pulled and tests are ran on the PR image.

@eriknordmark
Copy link
Contributor

@eriknordmark tests started to work, failures seems not related to changes in GitHub Actions. Image is pulled and tests are ran on the PR image.

Thanks. I'll merge this.

@uncleDecart
Copy link
Contributor Author

Merge conflict with this PR #4041. Eden should be bumped to 0.9.9 first and then this PR should be updated

@eriknordmark eriknordmark merged commit 17bad3f into lf-edge:master Jul 1, 2024
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants