Skip to content

uncommenting serialization tests

Sign in for the full log view
GitHub Actions / Clippy Output succeeded Nov 11, 2023 in 0s

Clippy Output

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 123 in src/package/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

call to `.clone()` on a reference in this situation does nothing

warning: call to `.clone()` on a reference in this situation does nothing
   --> src/package/mod.rs:123:33
    |
123 |                 return Some(path.clone().to_path_buf());
    |                                 ^^^^^^^^ help: remove this redundant call
    |
    = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed

Check warning on line 54 in src/backends/npm.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

call to `.clone()` on a reference in this situation does nothing

warning: call to `.clone()` on a reference in this situation does nothing
  --> src/backends/npm.rs:53:54
   |
53 |           let mut path_copy: Vec<OsString> = output_dir
   |  ______________________________________________________^
54 | |             .clone()
   | |____________________^ help: remove this redundant call
   |
   = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed
   = note: `#[warn(noop_method_call)]` on by default

Check warning on line 111 in src/backends/npm.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/backends/npm.rs:111:23
    |
111 |                 .join(&src_postfix)
    |                       ^^^^^^^^^^^^ help: change this to: `src_postfix`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 50 in src/backends/npm.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this creates an owned instance just for comparison

warning: this creates an owned instance just for comparison
  --> src/backends/npm.rs:50:44
   |
50 |             .position(|element| element == OsString::from("src"))
   |                                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `*"src"`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
   = note: `#[warn(clippy::cmp_owned)]` on by default