Stabilized LSP diagram genenation and added default expansion option #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should stabilize the diagram generation in VS Code. See lf-lang/vscode-lingua-franca#103 and this comment: lf-lang/vscode-lingua-franca#103 (comment)
cmnrd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dependency of the language server on
de.cau.cs.kieler.klighd.incrementalas suggested in this comment: lf-lang/vscode-lingua-franca#103 (comment). This seems to indeed stabilize the diagram generation.It further adds a new synthesis options that allows to control if new reactors should be expanded or contracted when added. This setting also influences if all reactors are expanded or contracted when opening a new LF file.
Closes lf-lang/vscode-lingua-franca#103
Perhaps this change also addresses lf-lang/vscode-lingua-franca#142, but we will need further testing.