Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klighd upgraded to v3.0.1 #2263

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Conversation

soerendomroes
Copy link
Collaborator

No description provided.

@soerendomroes soerendomroes marked this pull request as ready for review April 21, 2024 17:27
@soerendomroes
Copy link
Collaborator Author

This fails since the way of initializing and using Klighd changed (beginning with the 3.0.X release the functionality previously provided by klighd.standalone is provided in a different plugin). Maybe, @a-sr can point to the corresponding commit in kieler/semantics or @NiklasRentzCAU has prepared a guide to adapt the release.

@NiklasRentzCAU
Copy link

Sure, I can provide you some links and insight on what needs to be changed here.
Generally, the release notes of KLighD 3.0.1 state what needs to be changed according to the breaking changes in language server applications:

  1. Replace any de.cau.cs.kieler.klighd.standalone with de.cau.cs.kieler.klighd.setup (might not even occur in the files, as we changed that dependency downstream in klighd.lsp)

  2. Replace any occurence of de.cau.cs.kieler.klighd.standalone.KlighdStandaloneSetup in the source code to de.cau.cs.kieler.klighd.setup.KlighdStandaloneSetup.

  3. (recommended, but not strictly neccessary) remove the klighd.incremental dependency from your lsp/build.gradle: the animations now work even without this, this dependency is now only required in Eclipse-based applications, so not your language server.

If you do any manual injection stuff with KLighD, you also might need to update parts of that from the old javax.inject to jakarta.inject or com.google.inject with Google Guice >=7.0.0

The commit in semantics for the first two steps is here.

Neccessary changes that I see are here(change to .setup), and here (remove)

@lhstrh
Copy link
Member

lhstrh commented Apr 24, 2024

My guess is that the check for labels doesn't work correctly when the PR comes from a fork?

Nvm, looks like you added the label after the test.

@soerendomroes
Copy link
Collaborator Author

Epoch still seems to have problems with that. This should be the case since it uses an old version of ELK (and Klighd) in its target platform, which does not support the MODEL_ORDER option for separate connected components packing.
@lhstrh I did some things to get Epoch working with the new release but I do not know all dependencies by heart so lf-lang/epoch#65 should take a little longer to fix.

@lhstrh
Copy link
Member

lhstrh commented Apr 24, 2024

Epoch still seems to have problems with that. This should be the case since it uses an old version of ELK (and Klighd) in its target platform, which does not support the MODEL_ORDER option for separate connected components packing.

@lhstrh I did some things to get Epoch working with the new release but I do not know all dependencies by heart so lf-lang/epoch#65 should take a little longer to fix.

This is the part where @a-sr usually saves the day 😆

@lhstrh lhstrh changed the title Updated to Klighd 3.0.1 Klighd upgraded to v3.0.1 Apr 26, 2024
lsp/build.gradle Show resolved Hide resolved
@lhstrh lhstrh enabled auto-merge April 26, 2024 20:03
@lhstrh lhstrh added this pull request to the merge queue Apr 26, 2024
Merged via the queue into lf-lang:master with commit 0f9fa03 Apr 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants