pypasta: config: change default filename for cluster output #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rralf
requested changes
Apr 4, 2020
pypasta/Config.py
Outdated
| cluster_dst = 'MBOX_RESULT' | ||
| else: | ||
| cluster_dst = 'PASTA_RESULT' | ||
| cluster_dst = 'PATCH_GROUPS' |
There was a problem hiding this comment.
One last thing: You can use 'PATCH_GROUPS' directly below. There's no need for outsourcing it in a variable.
pypasta/Config.py
Outdated
| cluster_dst = 'MBOX_RESULT' | ||
| else: | ||
| cluster_dst = 'PASTA_RESULT' | ||
| cluster_dst = 'PATCH_GROUPS' | ||
| self.f_clustering = path(cluster_dst) |
The default filename for both patch stack and mbox mode is same now Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
rsarky
force-pushed
the
change-default-result-filename
branch
from
982327c
to
7b1c481
Compare
|
Thanks, applied! |
|
Ah crap, that was a bit too fast: Could you please forward the resources submodule? |
|
Sure! Will do once the PR is merged there. |
|
It is merged. |
|
This isnt merged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default filename for both patch stack and mbox mode is same now
Signed-off-by: Rohit Sarkar rohitsarkar5398@gmail.com