adapt instructions.md for CNTI #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor
reviewed
Mar 14, 2024
instructions.md
Outdated
| | `name` | Name of the product being certified. | | ||
| | `version` | The version of the product being certified. | | ||
| | `website_url` | URL to the product information website | | ||
| | `repo_url` | If your product is open source, this field is necessary to point to the primary GitHub repo containing the source. It's OK if this is a mirror. OPTIONAL | | ||
| | `documentation_url` | URL to the product documentation. OPTIONAL | | ||
| | `product_logo_url` | URL to the product's logo, (must be in SVG format -- not a PNG -- and include the product name). If not supplied, we'll use your company logo. Please see logo [guidelines](https://github.com/cncf/landscape#logos). | | ||
| | `product_logo_url` | URL to the product's logo, (must be in SVG format -- not a PNG -- and include the product name). If not supplied, we'll use your company logo. (TODO: LFN logo guidelines not found) Please see logo [guidelines](https://github.com/cncf/landscape#logos). | |
There was a problem hiding this comment.
@martin-mat @lixuna @Smitholi67 Maybe these guidelines can be copied over to the cnti certification repo or the cnti main repo. Either way that can be a new pull request
lixuna
reviewed
Mar 14, 2024
Refs lfn-cnti#74 Signed-off-by: Martin Matyas <martin.matyas@tietoevry.com>
martin-mat
force-pushed
the
cnti_instructions_adapt
branch
from
ddeac28
to
f69068a
Compare
martin-mat
changed the title
|
Certified product logo guidelines left to CNCF and not intended to adapt it in this PR. Created a new issue to address it subsequemntly (#94). Ready to review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #74
Pre-submission checklist:
Please check each of these after submitting your pull request: