Implement intrinsic `real` #4063

HarshitaKalani · 2024-05-22T11:25:07Z

HarshitaKalani · 2024-05-22T11:26:48Z

There are a number of files which fail with the current implementation. I'm working on them.
The following files fail with the replacement of old real function with new intrinsic real function

integration_tests/arrays_41.f90 Seg fault in fortran program utilizing nested sum function with intrinsic mask #4062
integration_tests/arrays_42.f90
integration_tests/implied_do_loops4.f90 Intrinsic functions with "kind_arg": True throw compiler error with implied_do_loops #4070
integration_tests/array_slice_04.f90

Edit - All of them are now resolved.

src/libasr/intrinsic_func_registry_util_gen.py

integration_tests/CMakeLists.txt

HarshitaKalani · 2024-06-12T07:50:09Z

Third party code failure

ASR verify pass error: ASR verify: The symbol table was not found in the scope of `symtab`.

ASR verify pass error: Var::m_v `result` cannot point outside of its symbol table
Internal Compiler Error: Unhandled exception
Traceback (most recent call last):
LCompilersException: Verify failed in the pass: subroutine_from_function
make[2]: *** [example/stats/CMakeFiles/example_mean.dir/build.make:75: example/stats/CMakeFiles/example_mean.dir/example_mean.f90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3863: example/stats/CMakeFiles/example_mean.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

HarshitaKalani · 2024-06-12T08:13:31Z

In stdlib

$ ./build_test_lf.sh 
.
.
.
[100%] Built target example_math_argpi
ASR verify pass error: ASR verify: The symbol table was not found in the scope of `symtab`.

ASR verify pass error: Var::m_v `result` cannot point outside of its symbol table
Internal Compiler Error: Unhandled exception
[100%] Linking Fortran executable example_math_is_close
[100%] Built target example_math_is_close
[100%] Linking Fortran executable test_selection
[100%] Built target test_selection
Traceback (most recent call last):
  Binary file "/home/harshita/Desktop/lfortran/src/bin/lfortran", in _start()
  File "./csu/../csu/libc-start.c", line 392, in __libc_start_main_impl()
  File "./csu/../sysdeps/nptl/libc_start_call_main.h", line 58, in __libc_start_call_main()
  File "/home/harshita/Desktop/lfortran/src/bin/lfortran.cpp", line 2481, in ??
    return main_app(argc, argv);
  File "/home/harshita/Desktop/lfortran/src/bin/lfortran.cpp", line 2410, in main_app(int, char**)
    return compile_to_object_file(arg_file, outfile, false,
  File "/home/harshita/Desktop/lfortran/src/bin/lfortran.cpp", line 954, in ??
    res = fe.get_llvm3(*asr, lpm, diagnostics, infile);
  File "/home/harshita/Desktop/lfortran/src/lfortran/fortran_evaluator.cpp", line 363, in LCompilers::FortranEvaluator::get_llvm3(LCompilers::ASR::TranslationUnit_t&, LCompilers::PassManager&, LCompilers::diag::Diagnostics&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    compiler_options, run_fn, infile);
  File "/home/harshita/Desktop/lfortran/src/libasr/codegen/asr_to_llvm.cpp", line 9906, in LCompilers::asr_to_llvm(LCompilers::ASR::TranslationUnit_t&, LCompilers::diag::Diagnostics&, llvm::LLVMContext&, Allocator&, LCompilers::PassManager&, LCompilers::CompilerOptions&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    pass_manager.apply_passes(al, &asr, co.po, diagnostics);
  File "/home/harshita/Desktop/lfortran/src/libasr/pass/pass_manager.h", line 315, in LCompilers::PassManager::apply_passes(Allocator&, LCompilers::ASR::TranslationUnit_t*, LCompilers::PassOptions&, LCompilers::diag::Diagnostics&)
    apply_passes(al, asr, _passes, pass_options, diagnostics);
LCompilersException: Verify failed in the pass: subroutine_from_function
make[2]: *** [example/stats/CMakeFiles/example_mean.dir/build.make:75: example/stats/CMakeFiles/example_mean.dir/example_mean.f90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3863: example/stats/CMakeFiles/example_mean.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

HarshitaKalani · 2024-06-12T08:17:29Z

Regarding the wasm failure:

$ lfortran integration_tests/complex_12.f90 wasm
(3.000000,4.000000)

And on running the following, all the test pass. Not sure, why is the wasm check failing.

$ ./integration_tests/run_tests.py -b wasm
.
.
.
100% tests passed, 0 tests failed out of 220

Label Time Summary:
c                 =   9.25 sec*proc (54 tests)
cpp               =   6.57 sec*proc (38 tests)
fortran           =  12.28 sec*proc (72 tests)
gfortran          =  33.54 sec*proc (192 tests)
llvm              =  38.19 sec*proc (217 tests)
llvm2             =   1.35 sec*proc (8 tests)
llvmImplicit      =   0.17 sec*proc (1 test)
llvmStackArray    =   7.10 sec*proc (39 tests)
llvm_wasm         =  38.01 sec*proc (216 tests)
llvm_wasm_emcc    =  38.01 sec*proc (216 tests)
wasm              =  38.72 sec*proc (220 tests)
x86               =   3.19 sec*proc (19 tests)

Total Test time (real) =   4.92 sec

certik · 2024-06-12T12:05:50Z

@Shaikh-Ubaid any idea why the WASM is failing?

Maybe it depends on the old real implementation somehow.

Shaikh-Ubaid · 2024-06-12T14:17:18Z

The return type of the generated intrinsic function is not perfect.

% cat integration_tests/complex_12.f90 
program main
    implicit none
    complex(8) :: k
    print *, kind(real(k))
end program
% gfortran integration_tests/complex_12.f90 
% ./a.out 
           8
% lfortran integration_tests/complex_12.f90 
4

Inside the intrinsic function we take an argument of kind 8 and assign it to a variable of kind 4 which leads to the wasm error (wasm has strict type checking).

% cat integration_tests/complex_12.f90                
program main
    implicit none
    complex(8) :: k
    print *, real(k)
end program

% lfortran integration_tests/complex_12.f90 --dump-all-passes
% cat pass_31_insert_deallocate.clj
...
...
                _lcompilers_real_c64:
                                (Variable
                                    3
                                    _lcompilers_real_c64
                                    []
                                    ReturnVar
                                    ()
                                    ()
                                    Default
                                    (Real 4)
                                    ()
                                    Source
                                    Public
                                    Required
                                    .false.
                                ),
...
...
...
                _lcompilers_real_c64
                    (FunctionType
                        [(Complex 8)]
                        (Real 4)
                        Source
                        Implementation
                        ()
                        .false.
                        .false.
                        .false.
                        .false.
                        .false.
                        []
                        .false.
                    )
                    []
                    [(Var 3 a)]
                    [(Assignment
                        (Var 3 _lcompilers_real_c64)
                        (ComplexRe
                            (Var 3 a)
                            (Real 4)
                            ()
                        )
                        ()
                    )]

Shaikh-Ubaid · 2024-06-12T14:20:58Z

Apart from the above, it seems the type of real() intrinsic is different based on the argument passed:

From https://gcc.gnu.org/onlinedocs/gfortran/REAL.html

These functions return a REAL variable or array under the following rules:

(A)
REAL(A) is converted to a default real type if A is an integer or real variable.

(B)
REAL(A) is converted to a real type with the kind type parameter of A if A is a complex variable.

(C)
REAL(A, KIND) is converted to a real type with kind type parameter KIND if A is a complex, integer, or real variable.

I think we currently handle the A case and C case (the kind_arg: True helps in this). For B case, I think we need to add support for it.

src/libasr/pass/intrinsic_functions.h

a.f90

HarshitaKalani · 2024-06-13T13:14:47Z

The third party code fails due to the following issue:

function func(x) result(res)
    integer :: x(:,:)
    real :: res
    print *, sum(real(x), 1) / 1.0
end function func

program main
end program

$ gfortran a.f90 && ./a.out
$ lfortran a.f90 
ASR verify pass error: ASR verify: The symbol table was not found in the scope of `symtab`.

ASR verify pass error: Var::m_v `result` cannot point outside of its symbol table
Internal Compiler Error: Unhandled exception
Traceback (most recent call last):
  Binary file "/home/harshita/Desktop/lfortran/src/bin/lfortran", in _start()
  File "./csu/../csu/libc-start.c", line 392, in __libc_start_main_impl()
  File "./csu/../sysdeps/nptl/libc_start_call_main.h", line 58, in __libc_start_call_main()
  File "/home/harshita/Desktop/lfortran/src/bin/lfortran.cpp", line 2481, in ??
    return main_app(argc, argv);
  File "/home/harshita/Desktop/lfortran/src/bin/lfortran.cpp", line 2442, in main_app(int, char**)
    err = compile_to_object_file(arg_file, tmp_o, false,
  File "/home/harshita/Desktop/lfortran/src/bin/lfortran.cpp", line 954, in ??
    res = fe.get_llvm3(*asr, lpm, diagnostics, infile);
  File "/home/harshita/Desktop/lfortran/src/lfortran/fortran_evaluator.cpp", line 363, in LCompilers::FortranEvaluator::get_llvm3(LCompilers::ASR::TranslationUnit_t&, LCompilers::PassManager&, LCompilers::diag::Diagnostics&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    compiler_options, run_fn, infile);
  File "/home/harshita/Desktop/lfortran/src/libasr/codegen/asr_to_llvm.cpp", line 9926, in LCompilers::asr_to_llvm(LCompilers::ASR::TranslationUnit_t&, LCompilers::diag::Diagnostics&, llvm::LLVMContext&, Allocator&, LCompilers::PassManager&, LCompilers::CompilerOptions&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
    pass_manager.apply_passes(al, &asr, co.po, diagnostics);
  File "/home/harshita/Desktop/lfortran/src/libasr/pass/pass_manager.h", line 315, in LCompilers::PassManager::apply_passes(Allocator&, LCompilers::ASR::TranslationUnit_t*, LCompilers::PassOptions&, LCompilers::diag::Diagnostics&)
    apply_passes(al, asr, _passes, pass_options, diagnostics);
LCompilersException: Verify failed in the pass: subroutine_from_function

certik · 2024-06-22T14:47:01Z

Looks like more work is needed, I'll mark it as draft for now.

certik

I think it's fine. Maybe later we can emit the cast directly for scalars, since that is what it will end up. I am a little worried about performance --- a simple line like:

a = real(b)

now becomes a function, which we must hope it gets inlined. It probably does, but it seems wasteful.

I think it's ok to merge, but probably requires more subsequent PRs.

HarshitaKalani · 2024-06-30T07:04:10Z

Yes, I got that.

HarshitaKalani added the intrinsic Issue or pull request specific to intrinsic function label May 22, 2024

HarshitaKalani mentioned this pull request May 23, 2024

GSoC: Intrinsic functions #4017

Open

54 tasks

HarshitaKalani force-pushed the real_01 branch from 4a99bfd to 6942922 Compare June 10, 2024 13:53

certik reviewed Jun 10, 2024

View reviewed changes

src/libasr/intrinsic_func_registry_util_gen.py Show resolved Hide resolved

HarshitaKalani mentioned this pull request Jun 12, 2024

Fix: add type check for ArrayPhysicalCast before downcasting #4241

Merged

HarshitaKalani force-pushed the real_01 branch from 6942922 to 95068e6 Compare June 12, 2024 07:39

HarshitaKalani commented Jun 12, 2024

View reviewed changes

src/libasr/intrinsic_func_registry_util_gen.py Outdated Show resolved Hide resolved

HarshitaKalani commented Jun 12, 2024

View reviewed changes

integration_tests/CMakeLists.txt Outdated Show resolved Hide resolved

HarshitaKalani force-pushed the real_01 branch from 95068e6 to c3d5429 Compare June 12, 2024 07:52

HarshitaKalani marked this pull request as ready for review June 12, 2024 07:53

Shaikh-Ubaid reviewed Jun 12, 2024

View reviewed changes

src/libasr/pass/intrinsic_functions.h Outdated Show resolved Hide resolved

HarshitaKalani force-pushed the real_01 branch from c3d5429 to 4c5489a Compare June 13, 2024 05:35

HarshitaKalani commented Jun 13, 2024

View reviewed changes

a.f90 Outdated Show resolved Hide resolved

HarshitaKalani force-pushed the real_01 branch 2 times, most recently from ca1879b to 1fc4bf1 Compare June 13, 2024 12:58

certik marked this pull request as draft June 22, 2024 14:46

This was referenced Jun 28, 2024

Verify failure in sngl intrinsic in subroutine_from_function pass #4409

Open

ci: remove dim in sum intrinsic in stdlib to make real work #4413

Merged

HarshitaKalani force-pushed the real_01 branch 2 times, most recently from a37922b to e0b8fe9 Compare June 30, 2024 03:39

HarshitaKalani marked this pull request as ready for review June 30, 2024 03:55

certik approved these changes Jun 30, 2024

View reviewed changes

HarshitaKalani added 7 commits June 30, 2024 12:29

remove old runtime implementation of real

4c0fdba

remove old comptime implementation of real

fbea17c

remove intrinsic real node

13dc343

feat: implement intrinsic real

ff9bb9c

fix: handle kind for complex arg

c0fdf3a

test: add and register test

18da660

test: update references

96c1710

test: add fortran label

cf2f9bf

HarshitaKalani force-pushed the real_01 branch from e0b8fe9 to cf2f9bf Compare June 30, 2024 07:05

HarshitaKalani enabled auto-merge June 30, 2024 07:06

HarshitaKalani merged commit d66f735 into lfortran:main Jun 30, 2024
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement intrinsic `real` #4063

Implement intrinsic `real` #4063

HarshitaKalani commented May 22, 2024

HarshitaKalani commented May 22, 2024 •

edited

Loading

HarshitaKalani commented Jun 12, 2024

HarshitaKalani commented Jun 12, 2024

HarshitaKalani commented Jun 12, 2024

certik commented Jun 12, 2024

Shaikh-Ubaid commented Jun 12, 2024 •

edited

Loading

Shaikh-Ubaid commented Jun 12, 2024 •

edited

Loading

HarshitaKalani commented Jun 13, 2024 •

edited

Loading

certik commented Jun 22, 2024

certik left a comment

HarshitaKalani commented Jun 30, 2024 •

edited

Loading

Implement intrinsic real #4063

Implement intrinsic real #4063

Conversation

HarshitaKalani commented May 22, 2024

HarshitaKalani commented May 22, 2024 • edited Loading

HarshitaKalani commented Jun 12, 2024

HarshitaKalani commented Jun 12, 2024

HarshitaKalani commented Jun 12, 2024

certik commented Jun 12, 2024

Shaikh-Ubaid commented Jun 12, 2024 • edited Loading

Shaikh-Ubaid commented Jun 12, 2024 • edited Loading

HarshitaKalani commented Jun 13, 2024 • edited Loading

certik commented Jun 22, 2024

certik left a comment

Choose a reason for hiding this comment

HarshitaKalani commented Jun 30, 2024 • edited Loading

Implement intrinsic `real` #4063

Implement intrinsic `real` #4063

HarshitaKalani commented May 22, 2024 •

edited

Loading

Shaikh-Ubaid commented Jun 12, 2024 •

edited

Loading

Shaikh-Ubaid commented Jun 12, 2024 •

edited

Loading

HarshitaKalani commented Jun 13, 2024 •

edited

Loading

HarshitaKalani commented Jun 30, 2024 •

edited

Loading