Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify-bar, no recurrent appointment #25

Closed
rgc69 opened this issue Feb 8, 2017 · 12 comments
Closed

Notify-bar, no recurrent appointment #25

rgc69 opened this issue Feb 8, 2017 · 12 comments

Comments

@rgc69
Copy link

rgc69 commented Feb 8, 2017

I noticed that no appointments appear in the notify-bar (next appointment within the upcoming 24 hours), if they are marked as recurrent. It's this correct? Thank you

EDIT: Nor notifications sends

@lfos
Copy link
Owner

lfos commented Feb 8, 2017

Probably not. I get notifications for recurrent items. Which calcurse version are you using? What does the item (line in the data file) look like?

@rgc69
Copy link
Author

rgc69 commented Feb 8, 2017

Hi, calcurse version 4.2.2. The line for a recurrent appointments looks like:
02/08/2017 @ 18:30 -> 02/08/2017 @ 19:15 {1D -> 03/01/2017} |Blacklist
Notify-bar (& notifications) works great with "normal" apointments:
02/14/2017 @ 09:00 -> 02/14/2017 @ 09:30|San Valentino

@lfos
Copy link
Owner

lfos commented Feb 8, 2017

Works fine for me. Can you try to reproduce the issue on a stock configuration? And maybe a data file which contains nothing but the recurrent item in question?

@rgc69
Copy link
Author

rgc69 commented Feb 8, 2017

I think I got it. It's a problem with notification.notifyall, and the '!' flag. Even if notification.notifyall=all (as far as I understand, in this way all the events are notified), only If I put a '!' on the recursive event, the remaining time to the recursive event is visible inside the notify-bar. And no matter what is the value of notification.notify ('all', 'flagged' or 'unflagged'), only the "normal" items (i.e. not the recurrent one's) are notified according to the value, and visible in the notify-bar. Just to be clear, with the recursive one, no matter the value of notification.notify, I have to put (or remove) the '!' flag (it's like a trick), and then I can see the remaining time in the notify-bar (but no notification in the end).

EDIT: as for the notification, I use notify-send, and with the recursive appointments I only see an empty bubble. I think it's a problem regarding the {} brackets of the recursive events. Try:
notify-send "calcurse -n" works fine with normal appointments ( 02/08/2017 @ 22:34 -> 02/08/2017 @ 22:35|Test) , and return an empty bubble with recursive one's ( 02/08/2017 @ 22:34 -> 02/08/2017 @ 22:35 {1D}| Test

lfos pushed a commit that referenced this issue Feb 9, 2017
The recur_apoint_starts_before() filter function expected the second
parameter to be passed by value, whereas its only caller passed the
value by reference. For consistency with apoint_starts_after(), change
the signature and the implementation of recur_apoint_starts_before()
such that the parameter is passed by reference.

Also, add a comment to the only caller of recur_apoint_starts_before()
to clarify on why recur_apoint_starts_before() is used.

Fixes GitHub issue #25.

Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
@lfos
Copy link
Owner

lfos commented Feb 9, 2017

I think I was able to debug and fix this, seems like it is not related to flagging at all. Could you please check the commit on current master and see whether it fixes the issue?

@lfos
Copy link
Owner

lfos commented Feb 9, 2017

Also, could you please open another ticket for the (unrelated) notify-send issue? Thanks!

@rgc69
Copy link
Author

rgc69 commented Feb 9, 2017

Now everything's fine, notify-bar and notify-send issues! Thank you very much!

@lfos lfos closed this as completed Feb 9, 2017
@chaosmonk1
Copy link

I have this problem with 4.3.0. Recurring events are not returned by calcurse -n

@lhca
Copy link
Contributor

lhca commented Sep 28, 2018

Can you confirm that at the time of your query the event were to happen after midnight (belonging to tomorrow)? If so, it will appear after midnight!

@chaosmonk1
Copy link

Thanks, you're right. After midnight the event appeared. Is there a way to override this behavior so that recurring events appear 24 hours in advance like non-recurring events do?

@lhca
Copy link
Contributor

lhca commented Sep 28, 2018

No. It's a bug, unfortunately. If you are not building calcurse yourself, you will have to wait for the next release.

If you do build calcurse yourself, you can have a look at my cloned repository. The first commit of the branch notify-review contains a fix (lhca@4cc6a55).

@chaosmonk1
Copy link

chaosmonk1 commented Sep 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants