-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce library requirement from C++17 to C++11 #32
Conversation
I don't know how to solve the MacOS problem, I don't have one to try out. I guess that if a use something like |
Thanks. Right now, I don't have access to MacOS as well but I'll take care of it. |
I am not sure how this results in the produced error but this should be done anyways: It makes no sense to call Either try If this won't work, i would recommend not to use std::string here but simply a raw char array and then construct a std::string using the char pointer and its size modified by the sysctl function when returning the result. I can also give these approaches a try at the start of the coming week if you want. |
I apologize for the clang formatting errors. I have Ubuntu 20 on my machine and I couldn't install clang-format-14. After a few tries, I ended up using an Ubuntu 22 Docker container and was able to fix the issues. |
I think it might be beneficial to add a new job to the CI to run |
Solve #31
I made some decisions that maybe you think would be better otherwise. If so, tell me and I'll change it.
For the record, I've only tried it on Linux, but I've also modified the apple and windows code.