Added Python 3.8-3.11 in CI test setup, and fixed several version-related bugs. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Python 3.9 introduced importlib.resources.files which replaces the deprecated pkg_resources. Since we support Python 3.8, we should conditionally import pkg_resources if Python version is <= 3.9 and import importlib.resources otherwise.
When the tracker thread is stopped in Python 3.11 in Github Actions, the last message logged to the INFO channel is not "Monitoring thread ended." but instead "The following components were found: [...]". This breaks our tests only in Github Actions. My hypothesis is that this happens due to a race, so this commit tests that in CI.
Snailed
pushed a commit
to Snailed/carbontracker
that referenced
this pull request
Jun 25, 2024
Add Python 3.8-3.11 in CI test setup, and fix several version-related bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
tox.ini, so one now can runtoxfor testing everything using test discovery, ortox -e py11 -- -k "test_case_search_string"for testing a specific test using a specific Python versionpyproject.tomlsuch thatlogs/andtest_logs/directories will not get detected as package folders. These directories are not checked in Git, but appears during testing. This just means that one does not have to runrm -rf logs/ test_logs/between test runs.pkg_resourcesorimportlibdepending on Python version.