Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need support for addIdentificationData-MSnExp,mzRident #232

Closed
lgatto opened this issue Jul 27, 2017 · 1 comment
Closed

Need support for addIdentificationData-MSnExp,mzRident #232

lgatto opened this issue Jul 27, 2017 · 1 comment

Comments

@lgatto
Copy link
Owner

lgatto commented Jul 27, 2017

See #231 for details.
lgatto pushed a commit that referenced this issue Jul 27, 2017
@LaurentGatto
working on addIdentificationData-MSnExp,mzRident - see issue #232
597ffea
lgatto pushed a commit that referenced this issue Jul 27, 2017
@LaurentGatto
add first implementation of addIdentificationData-MSnExp,mzRident - see
3a702b0 
#232
@lgatto
Copy link
Owner Author

lgatto commented Jul 27, 2017 •
edited
Loading

TODO:

  • unit tests
  • handle case with multiple mzid files in addIdentificationData-MSnExp,character (see 858dd4a)
  • unit test for multiple files (*)
  • update documentation and vignette.

(*) I tested this manually as I don't have any data (yet at least) in the package for the unit test.

Other:

@lgatto lgatto mentioned this issue Aug 2, 2017
Closed
@lgatto lgatto closed this as completed Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgatto