Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error on Bioc servers #561

Closed
lgatto opened this issue Nov 23, 2021 · 3 comments
Closed

Check error on Bioc servers #561

lgatto opened this issue Nov 23, 2021 · 3 comments
Assignees

Comments

@lgatto
Copy link
Owner

lgatto commented Nov 23, 2021

The following happens both in release and devel

* checking tests ...
  Running ‘testthat.R’
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
   5.       └─base::tryCatch(...)
   6.         └─base:::tryCatchList(expr, classes, parentenv, handlers)
   7.           └─base:::tryCatchOne(expr, names, parentenv, handlers[[1L]])
   8.             └─value[[3L]](cond)
  ── Error (test_methods-MChromatograms.R:621:5): .compare_chromatograms works ───
  Error in ``[<-`(`*tmp*`, j, i, value = m[i, j] <- compareChromatograms(x[[i]], 
      y[[j]], ALIGNFUN = ALIGNFUN, ALIGNFUNARGS = ALIGNFUNARGS, 
      FUN = FUN, FUNARGS = FUNARGS))`: subscript out of bounds
  Backtrace:
      █
   1. └─MSnbase:::.compare_chromatograms(list(chr1), list(chr2, chr3)) test_methods-MChromatograms.R:621:4
  
  [ FAIL 2 | WARN 1095 | SKIP 12 | PASS 2341 ]
  Error: Test failures
  Execution halted

@jorainer - could this be related to the recent commit #560 ?

@jorainer
Copy link
Collaborator

Could be - I would look into it.

@jorainer jorainer self-assigned this Nov 23, 2021
jorainer added a commit that referenced this issue Nov 24, 2021
- Fix `compareChromatograms`.
@jorainer
Copy link
Collaborator

I've now also added the fix into the RELEASE_3_14 branch - I guess that the unit tests will again fail - but maybe you @lgatto can verify locally on your setup and then eventually push to BioC?

@lgatto
Copy link
Owner Author

lgatto commented Nov 24, 2021

Tested locally and pushed to Bioc release.

@lgatto lgatto closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants