feat: XYShift block for translation transform #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-integration of the XYShift alignment method.
Related Issue
In the new version, the default alignment was done by 'AlignReferenceSources()', which used twirl. After discussion, Lionel suggested to reintegrate the simple XYShift algorithm as most tracking issues are translational.
Type of Change
I integrated a boolean parameter 'XYShift' in the 'AlignReferenceSources()' block. Furthermore, I expanded the 'ComputeTransform' block into two new blocks: first I duplicated the block and called it 'ComputeTransformTwirl' and then I reimplemented the XYShift block from an earlier version as the 'ComputeTransformXYShift' block. By default the parameter 'XYShift' is set to False, and so by default twirl is used for alignment, as is done in ver 3.0.0.
I have tested the algorithm on a few example dates, by visually checking the resulting stack and it shows no streaks and other features indicating that alignment would have failed. However, proper testing has not been done yet.
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.