Update supervisions channels in multi-channel recipes #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, did you test the recipes? If yes, LGTM! |
Not extensively. Give me a couple of days to make sure they are good to go. I'll let you know once I have verified them. |
|
I verified that the changes work for some of the recipes (LibriCSS, AMI). I think we can merge now and fix later if there are any issues. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #822, we updated the
channelattribute ofSupervisionSegmentto be able to represent a single channel or a list of channels. This PR updates the existing multi-channel recipes to use this capability. For example, in the AMI "mdm" setting, each supervision segment is shared across all the channels.