-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Swift 6 language mode and Swift Syntax 600.0.0 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Pull Request passed benchmark checks SummaryWed Jun 19 10:57:59 UTC 2024
New baseline 'pull_request' is WORSE than the 'main' baseline thresholds. Comparing results between 'main' and 'pull_request'
XCStringsToolBenchmarksStringGenerator.generateSource(for:tableName:accessLevel:) metrics
|
Oh, need to account for #available too |
liamnichols
force-pushed
the
ln/swift-6-compatibility
branch
from
June 19, 2024 09:51
800fc21
to
15b425b
Compare
liamnichols
force-pushed
the
ln/swift-6-compatibility
branch
from
June 19, 2024 09:59
15b425b
to
d9a9f25
Compare
liamnichols
force-pushed
the
ln/swift-6-compatibility
branch
from
June 19, 2024 10:36
758ec38
to
540b165
Compare
liamnichols
changed the title
Fix issues causing compile failures in Swift 6 language mode
Support Swift 6 language mode and Swift Syntax 600.0.0
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace between
@available
and the opening(
causes a compile failure in Swift 6. It was found in the generated code due to how Swift Syntax 5XX.X.X would format the output.This Pull Request does the following: