Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dead code, update docs #11

Merged
merged 4 commits into from
May 22, 2023
Merged

refactor: remove dead code, update docs #11

merged 4 commits into from
May 22, 2023

Conversation

rcoy-v
Copy link
Contributor

@rcoy-v rcoy-v commented May 22, 2023 •
edited
Loading

Changes

  • Update flag, usage, and github pull request documentation
  • Remove commit-sha flag
  • Minor, internal code refactoring
  • Update example digests used in Makefile

alexashley
alexashley previously approved these changes May 22, 2023
View reviewed changes
alexashley
alexashley reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@alexashley alexashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the use section, it's still referencing the old file name?

gh-trusted-builds-attestations/README.md

Line 9 in 86d349f

$ go run cmd/attestor.go <attestation-type> [--flag]

@rcoy-v rcoy-v merged commit 2f37a9a into main May 22, 2023
@rcoy-v rcoy-v deleted the clean-up branch May 22, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexashley alexashley alexashley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcoy-v @alexashley