Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add semantic-release #19

Merged
merged 3 commits into from
Jun 15, 2023
Merged

ci: add semantic-release #19

merged 3 commits into from
Jun 15, 2023

Conversation

alexashley
Copy link
Contributor

Also updates the README, as it was missing a few flags

@rcoy-v
Copy link
Contributor

rcoy-v commented Jun 14, 2023

This is using semantic release to only create a tag, which will start the separate build workflow with go releaser, correct? Could we, or does it make sense to, have semantic release also handle the release like the policy repository? https://github.com/liatrio/gh-trusted-builds-policy/blob/main/.releaserc#L21

@alexashley
Copy link
Contributor Author

This is using semantic release to just create a tag, which will start the separate build workflow with go releaser, correct

It shouldn't trigger a new workflow run, I removed the tags trigger and changed the release job to always run on main. Goreleaser just runs after and it should have the local tag.

The Goreleaser docs have an example of integrating with semantic-release but it's just using the exec plugin to run goreleaser. I don't see that as too different from just running the action, especially if we aren't going to create releases locally https://goreleaser.com/cookbooks/semantic-release/#example-semantic-release

@alexashley alexashley merged commit be98f9b into main Jun 15, 2023
@alexashley alexashley deleted the semantic-release branch June 15, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants