Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCRAM-SHA-256 authentication to this library #833

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Add SCRAM-SHA-256 authentication to this library #833

merged 3 commits into from
Apr 15, 2019

Conversation

raz-varren
Copy link
Contributor

@raz-varren raz-varren commented Mar 4, 2019

These changes add SCRAM-SHA-256 authentication to the pq library, by adding a slightly modified version of the mgo scram library and implementing it's functionality in the auth section of conn.go.

@hlinnaka
Copy link

hlinnaka commented Apr 8, 2019

See also PR #788 and PR #608.

@davidfetter
Copy link

Bump

@msva
Copy link

msva commented Apr 15, 2019

@mjibson ping? That PR looks like be based on current master and so nothing prevent it from merging.

@maddyblue maddyblue merged commit 51e2106 into lib:master Apr 15, 2019
@maddyblue
Copy link
Collaborator

We're entering the no tests yolo phase of lib/pq. But since this didn't touch any other auth methods, I'll just assume one of you tested that it works. If someone wants I'd merge a test for this.

@msva
Copy link

msva commented Apr 15, 2019

Yeah, at least, it was me, who checked it and, well, it connects, authenticates and looks like works fine

@ptman
Copy link

ptman commented Apr 16, 2019

@mjibson thanks for merging. did you look at the other PRs implementing it with tests?

@maddyblue
Copy link
Collaborator

When I looked those PRs weren't click-mergable, which is what I was looking for. If someone wants to port the tests from the other PRs I'll merge those, but I'm probably not going to do that myself.

@Neustradamus
Copy link

Please note that there were several PRs for this point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants