-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCRAM-SHA-256 authentication to this library #833
Conversation
Bump |
@mjibson ping? That PR looks like be based on current master and so nothing prevent it from merging. |
We're entering the no tests yolo phase of lib/pq. But since this didn't touch any other auth methods, I'll just assume one of you tested that it works. If someone wants I'd merge a test for this. |
Yeah, at least, it was me, who checked it and, well, it connects, authenticates and looks like works fine |
@mjibson thanks for merging. did you look at the other PRs implementing it with tests? |
When I looked those PRs weren't click-mergable, which is what I was looking for. If someone wants to port the tests from the other PRs I'll merge those, but I'm probably not going to do that myself. |
Please note that there were several PRs for this point... |
These changes add SCRAM-SHA-256 authentication to the pq library, by adding a slightly modified version of the mgo scram library and implementing it's functionality in the auth section of conn.go.