Begin contains_vertex_of with node equality tests #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be a little slower when testing 2-level-different AMR neighbors and/or non-neighbors, but the extra speed when testing most neighbors seems to make it a big win in my benchmarks.
|
Finally tried this out with one of the tests Fande recommended for me, and it makes DistributedMesh refinement about 150% (2.5x) faster in that one. Still not nearly fast enough for us to consider the problem solved and done with, but too good not to merge in the meantime. |
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be a little slower when testing 2-level-different AMR neighbors
and/or non-neighbors, but the extra speed when testing most neighbors
seems to make it a big win in my benchmarks.
Hoping @fdkong will see whether this gives him much improvement with his own distributed mesh refinement cases.