Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configure support for --with-xdr-include option #3711

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

jwpeterson
Copy link
Member

@jwpeterson jwpeterson commented Nov 16, 2023

RPC headers can be installed in places other than /usr/include/tirpc so let the user specify the correct PATH.

Closes #3709.

@mboisson
Copy link

Will this also work from an environment variable ? Unfortunately, some packages bundle libMesh in their build script, and there's no way to change the options passed to configure without patching the build scripts.

@jwpeterson
Copy link
Member Author

Will this also work from an environment variable ?

No this patch won't work with an environment variable as-is. I think I can fix that, but FYI if you are building the libmesh used by MOOSE, it should be possible to pass additional configure flags to the script you call to build libmesh (at least it was possible at one time), so in that case you wouldn't need to patch the build scripts.

@mboisson
Copy link

ah, indeed there are options to the script (though I did not see it in the documentation, they just say to run the script as is without referring to any option).

@moosebuild
Copy link

Job Coverage on 4031892 wanted to post the following:

The following coverage requirement(s) failed:

  • Failed to generate coverage rate (required: 55.0%)

@jwpeterson jwpeterson merged commit 7d639b2 into libMesh:devel Nov 17, 2023
20 of 21 checks passed
@jwpeterson jwpeterson deleted the xdr_path_3709 branch November 20, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded /usr/include/tirpc path
4 participants