-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating subvectors only supplying local indices #3857
Allow creating subvectors only supplying local indices #3857
Conversation
Also add some sanity checking about the parallel type of the subvector
Job Coverage on 6bdf108 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
const std::vector<numeric_index_type> &) const | ||
const std::vector<numeric_index_type> &, | ||
bool = true) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some documentation for the new parameter? Since it doesn't even have a name here in the base class declaration, it's a bit mysterious as to what it might be for...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My very poor excuse for why I didn't do this initially is that I will have to comment out the parameter name to avoid unused warnings. Will a commented out parameter name still show up in the doxygen? Either way I can still articulate something in the doxygen wrt that parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relevant issue: doxygen/doxygen#6926
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'll merge later today unless @roystgnr has any objections or gets to it first.
Test MOOSE mac failure definitely seems unrelated:
|
Also add some sanity checking about the parallel type of the subvector