XML Parser Updates #175
Merged
XML Parser Updates #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressure limits are
the falloff specification: - in a falloff environment, only one "name" attribute is allowed - in a falloff environment, only the value "k0" for this attribute is allowed
in the default rate constant block
- one to test the name="k0" multiple attribute (fail_parsing_xml_1) - another to test the value other than "k0" restriction (fail_parsing_xml_2) We use the same program than for the regular xml test. The xml files only inclue the reaction to trigger the failure. Some update of the test had to be made: it requires three input files, originally, only the path to the folder was given, the names of the files were hard coded in the code. Now all three files are given explicitely in the sh file.
Closed
|
Will merge once tests successfully complete. |
|
This will close #173. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #174. The only changes I made were to the last commit where I shortened the XML files to only have the failing reaction (and added a comment about what we were testing).