archive_digest: check return value of EVP_DigestInit() #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function returns 0 on error, which is seemingly very common with OpenSSL 3.0 and rmd160. Just error check the lot, so we don't get even more random failures with future releases of OpenSSL. Fixes libarchive#1549 Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
espindula
pushed a commit
to espindula/br-blfs
that referenced
this pull request
Dec 9, 2022
The test failure with OpenSSL 3 is fixed by upstream: libarchive/libarchive#1717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function returns 0 on error, which is seemingly very common with
OpenSSL 3.0 and rmd160.
Just error check the lot, so we don't get even more random failures with
future releases of OpenSSL.
Fixes #1549
Signed-off-by: Emil Velikov emil.l.velikov@gmail.com