Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle STT_GNU_IFUNC ELF symbols #210

Closed
danielocfb opened this issue Jun 6, 2023 · 1 comment · Fixed by #499
Closed

Correctly handle STT_GNU_IFUNC ELF symbols #210

danielocfb opened this issue Jun 6, 2023 · 1 comment · Fixed by #499
Assignees
@d-e-s-o

Comments

@danielocfb
Copy link
Collaborator

danielocfb commented Jun 6, 2023 •
edited
Loading

See discussion here.

https://sourceware.org/glibc/wiki/GNU_IFUNC and https://www.airs.com/blog/archives/403 have some information.

I haven't fully read through everything, but this may be an easy task. I suspect that the loader does all the magic for us and we'd just need to have sure to handle STT_GNU_IFUNC in addition to STT_FUNC, but we'd need to double check.
@danielocfb danielocfb mentioned this issue Jun 6, 2023
Merged
@danielocfb danielocfb added the help wanted Extra attention is needed label Jun 7, 2023
@d-e-s-o
Copy link
Collaborator

d-e-s-o commented Jan 17, 2024

This may become a requirement for bpftrace integration, as it seems to explicitly query these symbols.

@d-e-s-o d-e-s-o self-assigned this Jan 24, 2024
@d-e-s-o d-e-s-o removed the help wanted Extra attention is needed label Jan 24, 2024
@danielocfb danielocfb linked a pull request Jan 25, 2024 that will close this issue
Add support for STT_GNU_IFUNC and STT_OBJECT ELF symbols types #499
Merged
d-e-s-o added a commit that referenced this issue Jan 26, 2024
@d-e-s-o
Add support for STT_GNU_IFUNC
ab76985 
Add support for indirect functions to our ELF parser logic, such that
they are treated as regular functions from blazeym's perspective.

Closes: #210

Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-e-s-o d-e-s-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for STT_GNU_IFUNC and STT_OBJECT ELF symbols types danielocfb/blazesym
2 participants
@d-e-s-o @danielocfb