Rename tests requiring root #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakryiko
approved these changes
May 17, 2023
Let's co-locate the map_info test with the remaining end-to-end tests for easier management. Signed-off-by: Daniel Müller <deso@posteo.net>
We have some complicated and non-obvious logic for skipping certain tests when running cargo test from the root of the crate in CI, but then an explicit invocation from the libbpf-rs/ sub-directory attempting to run those skipped tests (now under sudo). Simplify the logic and hopefully make it somewhat more obvious by prefixing all tests that require root with `test_sudo_`. Note: this is a workaround for what I'd call a bug in Cargo. I opened rust-lang/cargo#12147 in the hopes that this will be addressed eventually (though I don't know how realistic that is). If we are still getting confusion even with this more explicit naming, we may want to consider moving (or copying) libbpf-rs's .cargo/ directory into the workspace root. Signed-off-by: Daniel Müller <deso@posteo.net>
danielocfb
force-pushed
the
topic/map-info-test
branch
from
83ff86a
to
ae44910
Compare
Sure, I changed the prefix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some complicated and non-obvious logic for skipping certain
tests when running cargo test from the root of the crate in CI, but then
an explicit invocation from the libbpf-rs/ sub-directory attempting to
run those skipped tests (now under sudo).
Simplify the logic and hopefully make it somewhat more obvious by
prefixing all tests that require root with
test_root_.Note: this is a workaround for what I'd call a bug in Cargo. I opened
rust-lang/cargo#12147 in the hopes that this
will be addressed eventually (though I don't know how realistic that
is). If we are still getting confusion even with this more explicit
naming, we may want to consider moving (or copying) libbpf-rs's .cargo/
directory into the workspace root.