libbpf-rs: add support for bpf_map_update_batch method #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this support! Will take a look this week. |
danielocfb
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Apologies for the delay. Library code looks fine to me, but for the test:
- can you please add
///comment what it does (check other tests) - use proper identifyable keys and values as is done in
test_sudo_object_map_delete_batch, for example (otherwise the workings are hard to understand) - let's please cover the error cases where key and value sizes don't match
Looks good to me other than that.
Signed-off-by: yogaraj.s <yogaraj.s@zohocorp.com>
danielocfb
approved these changes
Dec 5, 2023
danielocfb
pushed a commit
that referenced
this pull request
Dec 5, 2023
Add a CHANGELOG entry for the changes made as part of #617. Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #607