Remove unsafe and platform dependent errno retrieval #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent addition of user ring buffers included calls to `*libc::__errno_location()`. Apart from requiring an unsafe block, this function might not be available on some targets, such as Android, causing build failures. Use the portable implementation provided by `std::io::Error::last_os_error` instead.
danielocfb
approved these changes
May 20, 2024
danielocfb
pushed a commit
that referenced
this pull request
May 20, 2024
Add a CHANGELOG entry for pull request #789, which fixed build issues on Android. Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of user ring buffers included calls to
*libc::__errno_location().Apart from requiring an unsafe block, this function might not be available on some targets, such as Android, causing build failures.
Use the portable implementation provided by
std::io::Error::last_os_errorinstead.