Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cost事件新增skill_popup属性;技能修改 #1439

Merged
merged 3 commits into from
Jun 5, 2024
Merged

cost事件新增skill_popup属性;技能修改 #1439

merged 3 commits into from
Jun 5, 2024

Conversation

mengxinzxz
Copy link
Contributor

@mengxinzxz mengxinzxz commented Jun 5, 2024

PR受影响的平台

所有平台

诱因和背景

①手杀公告の【秉清】结算描述修改
②cost事件对于是否logSkill的自由度不高
③日本知名漫画家jjxx开始接手OL武将后续调整[doge]

PR描述

①修改毛玠【秉清】结算
②cost事件新增skill_popup属性,当event.result存在skill_popup属性且Boolean(skill_popup)为false时,将不执行logSkill操作
③添加OL为裴秀添加的补丁(OL你无敌了)

PR测试

跑了能过

扩展适配

检查清单

  • 我已经进行了充足的测试,且现有的测试都已通过
  • 如果此次PR中添加了新的武将/新的语音文件,则我已在character/rank.js中添加对应的武将强度评级/在lib.translate中加入语音文件的文字台词
  • 如果此次PR涉及到新功能的添加,我已在PR描述中写入详细文档
  • 如果此次PR需要扩展跟进,我已在扩展适配中写入详细文档
  • 如果这个PR解决了一个issue,我在诱因和背景中明确链接到该issue
  • 我保证该PR中没有随意修改换行符等内容,没有制造出大量的Diff
  • 我保证该PR遵循项目中.editorconfigeslint.config.mjsprettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码

@mengxinzxz mengxinzxz changed the title cost事件新增skill_popup属性;【秉清】修改 cost事件新增skill_popup属性;技能修改 Jun 5, 2024
@Spmario233 Spmario233 merged commit e792223 into libccy:PR-Branch Jun 5, 2024
@Spmario233 Spmario233 mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants