Set up versions with last digit a pyerfa fix number. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalentino
requested changes
May 11, 2020
setup.py
Outdated
|
|
||
| ERFA_SRC = os.path.abspath(os.path.join(ERFAPKGDIR, 'liberfa', 'erfa', 'src')) | ||
| LIBERFADIR = os.path.abspath(os.path.join(ERFAPKGDIR, 'liberfa', 'erfa')) | ||
| ERFA_SRC = os.path.abspath(os.path.join(LIBERFADIR, 'src')) |
There was a problem hiding this comment.
Please consider to adjust the above lines to avoid absolute paths (see also #29).
There was a problem hiding this comment.
Please also:
ERFA_SRC = os.path.abspath(os.path.join(LIBERFADIR, 'src'))
should become
ERFA_SRC = os.path.join(LIBERFADIR, 'src')
Also the Extension object seems to injects paths into the egg-info/SOURCES.txt
|
I'm still not sure about the version number, but will continue that discussion in #7. |
Closed
mhvk
commented
May 31, 2020
|
|
||
|
|
||
| # https://mail.python.org/pipermail/distutils-sig/2007-September/008253.html | ||
| class NumpyExtension(setuptools.Extension): | ||
| """Extension type that adds the NumPy include directory to include_dirs.""" | ||
|
|
||
| def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
I removed this as we do not use cython so it seemed meaningless.
avalentino
approved these changes
May 31, 2020
|
|
||
|
|
||
| # https://mail.python.org/pipermail/distutils-sig/2007-September/008253.html | ||
| class NumpyExtension(setuptools.Extension): | ||
| """Extension type that adds the NumPy include directory to include_dirs.""" | ||
|
|
||
| def __init__(self, *args, **kwargs): |
|
OK, let's get this in. With #33 I think we'll be ready for a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at the four-digit version number. Still not sure I actually like it all that much, since the way things are set up, the python wrappers are fairly erfa-version agnostic.
Also note the hack in the tests to work around the fact that in our self-compilation we get the wrong erfa version number (see liberfa/erfa#62)