Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still requiring old sphinx < 6 #76

Closed
ThomasWaldmann opened this issue May 21, 2023 · 6 comments
Closed

still requiring old sphinx < 6 #76

ThomasWaldmann opened this issue May 21, 2023 · 6 comments
Assignees
Milestone

Comments

@ThomasWaldmann
Copy link
Collaborator

due to the sphinxcontrib-asyncio plugin, we still need to use the old sphinx version.

@ThomasWaldmann ThomasWaldmann added this to the 3.3.0 milestone May 21, 2023
@ThomasWaldmann
Copy link
Collaborator Author

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/sphinx/domains/python.py", line 547, in handle_signature
    raise TypeError(
TypeError: Python directive method get_signature_prefix() must return a list of nodes. Return value was 'coroutine '.
The full traceback has been saved in /tmp/sphinx-err-t267nzfq.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
reading sources... [ 50%] fuse_api

@ThomasWaldmann
Copy link
Collaborator Author

@ThomasWaldmann ThomasWaldmann removed this from the 3.3.0 milestone May 22, 2023
@ThomasWaldmann
Copy link
Collaborator Author

ThomasWaldmann commented Aug 7, 2023

https://sphinxcontrib-asyncio.readthedocs.io/en/latest/

Keywords provided by that extension (and usage by pyfuse3 docs):

  • cofunction
  • comethod
  • :async-with:
  • :async-for:
  • :coroutine:
  • autocofunction (used once, for pyfuse3.main)
  • autocomethod

@ThomasWaldmann
Copy link
Collaborator Author

Considering that extension seems to be unmaintained and it is only used for one function (and there only to extract "Run FUSE main loop"), guess we could just get rid of it?

@Nikratio ^^

@ThomasWaldmann ThomasWaldmann added this to the 3.3.1 milestone Aug 7, 2023
@Nikratio
Copy link
Contributor

Nikratio commented Aug 7, 2023

I believe the functionality is now available in Sphinx core (but maybe with slightly different keywords): sphinx-doc/sphinx#1826

@ThomasWaldmann
Copy link
Collaborator Author

@Nikratio ah, thanks for the hints.

It was not implemented by that PR though (that one was closed unmerged), but with sphinx-doc/sphinx#6295 .

@ThomasWaldmann ThomasWaldmann self-assigned this Aug 7, 2023
ThomasWaldmann added a commit that referenced this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants