Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade robovm to 2.3.19 #35

Merged
merged 3 commits into from
Apr 28, 2023
Merged

upgrade robovm to 2.3.19 #35

merged 3 commits into from
Apr 28, 2023

Conversation

klianc09
Copy link
Contributor

This fixes #34.

Also upgraded the robovm gradle plugin to match the robovm version (2.3.19)
I also upgraded libGDX to the newest version (1.11.0), IDK if that's okay.
I saw in test/lwjgl3/build.gradle there is a comment relating to libGdx versions not sure if that's relevant.

Only thing I did test or verify was:

  • execute ./gradlew clean uploadArchives -PLOCAL=true like it says in the readme (builds successfully)
  • used my locally build snapshot artifact in my game to verify that the error in Incompatible with RoboVM 2.3.19 #34 no longer shows up (error no longer shows up)

remove 'natives-armeabi' dependency from android, as support was dropped since libgdx 1.10.0
add more natives to gitignore
@klianc09
Copy link
Contributor Author

klianc09 commented Apr 27, 2023

Alright, now also made sure the test projects build without errors, verifying the gradle commands from the workflow file build successfully

Only needed to remove one dependency from the android test project (natives-armeabi)

Then saw that for some reason two .so files were checked in and were registered as being changed. I added them to the gitignore, because it looks like an oversight to me that they aren't. Feel free to correct me.

@MrStahlfelge
Copy link
Member

We should not raise the gdx version when not needed as this makes the lib unusable for this versions (without further gradle hacking). Everything else is fine!

@klianc09
Copy link
Contributor Author

Alright, should I just add another commit, or clean up the history? I'm not sure, can I just change the history of a pull request, or do I need to make a new one?

@MrStahlfelge
Copy link
Member

Just make a new commit, we can squash merge

@klianc09 klianc09 changed the title upgrade robovm to 2.3.19 and libGdx to 1.11.0 upgrade robovm to 2.3.19 Apr 28, 2023
@klianc09
Copy link
Contributor Author

alright undid the libgdx version upgrade

@MrStahlfelge MrStahlfelge merged commit 9e0c446 into libgdx:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with RoboVM 2.3.19
2 participants