Removed login dialog when installing InApps for Huawei #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll handleInstallError when user is not logged in. There was a problem when installing InApps when user is logged out. HuaweiPurchaseManager was opening login window - handleInstallError was not called and InApp products was still not installed after successful login.
|
Thanks for your contribution. How can the user login, is it possible via an other app? |
|
Yes, user can login via Huawei AppGallery app. If logged once he will be logged all the time unless he click to log out. |
|
Good to know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed login dialog when installing InApps for Huawei. Changed to call handleInstallError when user is not logged in.
There was a problem when installing InApps when user is logged out. HuaweiPurchaseManager was opening login window - handleInstallError was not called and InApp products was still not installed after successful login. I think that it will be better to call handleInstallError and leave it to a programmer - he can open login window or show text dialog.