GWT Accelerometer: report availability only if sensor is present #5758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrStahlfelge
changed the title
SimonIT
approved these changes
Aug 14, 2019
intrigus
suggested changes
Aug 14, 2019
MobiDevelop
reviewed
Aug 20, 2019
backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/GwtInput.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GWT Accelerometer is reported as present if the web browser supports it even if there is no accelerometer. This is not correct, using Chrome on Desktop reports an available accelerometer.
This commit changes getPeriphalAvailable in a way that accelerometer availability is only returned if real sensor data is present, this matches the behaviour of the other platforms.
Note: At first I wanted to use the onError callback of the sensor, but it was called on my mobile device too. I was not able to find out why, because the callback provides no error message.
Sorry for the diff. GwtInput had CRLF line endings which I was not able to commit. I think this is okay because (most) libGDX sources have LF line endings in general.