Improved isAndroid check in SharedLibraryLoader Should fix #5863

[mquickmann]

Improved Android check for newer Versions. Should fix #5863

[EtK2000]

What if you checked just for "Android".
Should still be correct, and might catch weird custom ROMs that change it, all without changing much.

IDK about case sensitivity though.

[PokeMMO]

Detecting Android is not a problem. The only "Problem" was that certain debug strings were printing incorrect data.

https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/utils/SharedLibraryLoader.java#L124-L125

This change is unnecessary.

[mquickmann]

What if you checked just for "Android".
Should still be correct, and might catch weird custom ROMs that change it, all without changing much.

IDK about case sensitivity though.

@EtK2000 you might be right, checking some properties with case sensitivity would make it possible to catch custom roms and might fix just some library loading issues depending on some special devices.

Detecting Android is not a problem. The only "Problem" was that certain debug strings were printing incorrect data.

https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/utils/SharedLibraryLoader.java#L124-L125

This change is unnecessary.

@PokeMMO Yes, that's correct. I've seen to late that the Exception is thrown on Line 119, like descriped in #5863 (comment):

libgdx/gdx/src/com/badlogic/gdx/utils/SharedLibraryLoader.java

Line 119 in 11a53e2

System.loadLibrary(platformName);

So what do you recommend closing pr or change the check of the Properties (and rename the pr) to support custom roms, described by @EtK2000 's answer (#5897 (review))?

[PokeMMO]

I am not aware of any custom rom not being properly detected, so I would recommend closing.