GWT: Initial call to set viewport size fails for resizable application #6329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MobiDevelop
approved these changes
Dec 25, 2020
SimonIT
approved these changes
Dec 25, 2020
|
Thanks for the quick approvals guys ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3cbe98 introduced resizable applications with no configured with and height, therefore
config.widthandconfigh.heightbeing 0.The initial call to set the viewport size still based on this constants, causing this call to set an invalid size for resizable applications. This was not noticed because our tests and most games use an own viewport, but of all things, our starter template generated by gdx-setup fails to render correctly without this fix.