Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimizing error #18

Closed
patriciog opened this issue Jun 17, 2014 · 3 comments
Closed

Minimizing error #18

patriciog opened this issue Jun 17, 2014 · 3 comments

Comments

@patriciog
Copy link

Hi guys:

I'm receiving this error message using openjdk-1.7.0-u60-unofficial-windows-i586-image.zip with soft profile:

Unpacking JRE
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further detail
s.
copying resources
minimizing JRE
unpacking rt.jar
Exception in thread "main" java.io.FileNotFoundException: File does not exist: o
ut4\jre\lib\rt\com\sun\corba \se
        at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
        at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044)
        at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977)
        at com.badlogicgames.packr.Packr.minimizeJre(Packr.java:194)
        at com.badlogicgames.packr.Packr.pack(Packr.java:153)
        at com.badlogicgames.packr.Packr.main(Packr.java:302)

I'm receiving another error message using openjdk-1.7.0-u60-unofficial-windows-i586-image.zip with hard profile:

Unpacking JRE
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further detail
s.
copying resources
minimizing JRE
unpacking rt.jar
Exception in thread "main" java.io.FileNotFoundException: File does not exist: o
ut4\jre\lib\rt\com\sun\jndi \url
        at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1386)
        at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1044)
        at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:977)
        at com.badlogicgames.packr.Packr.minimizeJre(Packr.java:194)
        at com.badlogicgames.packr.Packr.pack(Packr.java:153)
        at com.badlogicgames.packr.Packr.main(Packr.java:302)

Without minimizing I don't receive any error. Have I to use another jdk/jre?

Best regards!

@badlogic
Copy link
Member

Hm, we should probably make minimization more lenient and not have it crash in case a file couldn't be deleted. We should instead just output a warning.

@tommyettinger
Copy link
Member

I can reproduce this on windows. It appears to be an end-of-line issue with these resources in the Packr jar: minimize/soft and minimize/hard . Editing those files, removing some whitespace of an unclear type (it made notepad act strangely, at least, which makes me think it's a non-windows line ending), and replacing with the windows line ending appears to make it not crash with these resources. I can't verify that the exe runs due to another issue that I'll post separately.

@patriciog
Copy link
Author

Thank you very much, @tommyettinger and @badlogic . We were having problems with a button and we couldn't use packr like we wished :(

This troublesome button worked in the jar, but crashed in the exe when I was testing it on different versions of windows (XP, 7, 8.1...). We spent a lot of time working in this issue. As they didn't want to change the behaviour of the button, then I had to change the release software. I decided to use jsmooth to generate the exe, because the button worked well in all versions of windows.

I'm sorry for recommending another software in my response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants