DistanceOp: Add short-circuit for point-point distance

[dbaston]

Relates to #1066

Add a short circuit to reduce point-point computation time by ~90%.

[dr-jts]

Good find, @dbaston . Can you add the benchmark output to this PR for ease of seeing it?

[dr-jts]

I guess there could be some other optimizations added as well, such as Point-Linestring, or perhaps LineString-LineString? But maybe the returns diminish very quickly.

[dbaston]

It looks like there is opportunity for more improvements to the general case. For example, in the point-point case we are spending ~50% of the total time in PolygonExtracter and PointExtracter (without this short-circuit):

[dr-jts]

It looks like there is opportunity for more improvements to the general case. For example, in the point-point case we are spending ~50% of the total time in PolygonExtracter and PointExtracter (without this short-circuit):

Yes, perhaps some checking of dimensions could avoid calling the extracters if there is nothing for them to extract.

[dbaston]

Can you add the benchmark output to this PR for ease of seeing it?

main:

Running bin/perf_distance
Run on (8 X 4200 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x4)
  L1 Instruction 32 KiB (x4)
  L2 Unified 256 KiB (x4)
  L3 Unified 6144 KiB (x1)
Load Average: 0.66, 0.69, 0.83
***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead.
----------------------------------------------------------------
Benchmark                      Time             CPU   Iterations
----------------------------------------------------------------
BM_PointPointDistance   23094470 ns     23093762 ns           31

this PR:

2024-04-15T14:46:45-04:00
Running bin/perf_distance
Run on (8 X 4200 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x4)
  L1 Instruction 32 KiB (x4)
  L2 Unified 256 KiB (x4)
  L3 Unified 6144 KiB (x1)
Load Average: 0.55, 0.67, 0.82
***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead.
----------------------------------------------------------------
Benchmark                      Time             CPU   Iterations
----------------------------------------------------------------
BM_PointPointDistance    2136982 ns      2136823 ns          328