Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreparedLineStringIntersects: Fix incorrect result for mixed-dim GC with points #774

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Dec 12, 2022

@dr-jts JTS appears to be affected by the same issue.

@dbaston dbaston added the Bug label Dec 12, 2022
@dbaston
Copy link
Member Author

dbaston commented Dec 12, 2022

@dr-jts
Copy link
Contributor

dr-jts commented Dec 12, 2022

PreparedGeometry has some level of longstanding support:

Right, I see that now. I guess it got introduced at some point since it's easier to do with the Prepared Geometry algorithms. So should be fixed.

@dbaston dbaston force-pushed the prep-linestring-gc-intersects branch from 6d6f2fc to 34defd3 Compare December 12, 2022 21:51
@dbaston
Copy link
Member Author

dbaston commented Dec 12, 2022

So should be fixed.

Are you OK with this fix?

@dr-jts
Copy link
Contributor

dr-jts commented Dec 12, 2022

As far as I remember (and substantiated by absence of any documentation around support for Prepared Geometry with GeometryCollections), this was more of a "support by happenstance" than a planned extension. So there may well be other issues in the code.

@dr-jts
Copy link
Contributor

dr-jts commented Dec 12, 2022

Should add unit tests for the new Geometry.hasDimension method.

@dr-jts
Copy link
Contributor

dr-jts commented Dec 12, 2022

See matching JTS PR locationtech/jts#944

@dbaston dbaston merged commit de4fb92 into libgeos:main Dec 13, 2022
dr-jts pushed a commit that referenced this pull request Nov 1, 2023
dr-jts pushed a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants