-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PreparedLineStringIntersects: Fix incorrect result for mixed-dim GC with points #774
Conversation
PreparedGeometry has some level of longstanding support: https://github.com/locationtech/jts/blob/master/modules/tests/src/test/resources/testxml/general/TestPreparedPredicatesWithGeometryCollection.xml |
Right, I see that now. I guess it got introduced at some point since it's easier to do with the Prepared Geometry algorithms. So should be fixed. |
6d6f2fc
to
34defd3
Compare
Are you OK with this fix? |
As far as I remember (and substantiated by absence of any documentation around support for Prepared Geometry with GeometryCollections), this was more of a "support by happenstance" than a planned extension. So there may well be other issues in the code. |
Should add unit tests for the new |
See matching JTS PR locationtech/jts#944 |
@dr-jts JTS appears to be affected by the same issue.